Skip to content

videojs/rfcs

Folders and files

NameName
Last commit message
Last commit date

Latest commit

 

History

24 Commits
 
 
 
 
 
 
 
 
 
 

Repository files navigation

Video.js RFCs

The "RFC" (request for comments) process is for having a place to discussion big changes that may affect many pieces of the Video.js ecosystem so that stakeholders can be confident on the direction of the project.

Some changes, like bug fixes, small features, and documentation updates, can be done via the normal GitHub process.

Before submitting a proposal

If you have a new idea, it might be worth creating an issue to discuss it a bit first before submitting a proposal to make sure that it's something could be a good fit and won't be less likely to be rejected later on.

Submitting a proposal

  • Fork the repo
  • Copy 0000-template.md to proposals/0000-your-feature.md. Don't change the number yet as that will be updated when the PR is created.
  • Fill out your proposal with as much detail as possible.
  • Submit a pull request. Once the PR is created, a new commit can be made to update the filename 0000- prefix and the header of the file to point to the new PR number.
  • Folks should now review the proposal and suggest changes. While in the PR, it's expected that many changes may be made. Ideally, please don't rebase commits in the branch as it'll make reviewing only new changes easier.
  • At some point, a committer should issue a Call for Consensus (CfC). This CfC will include whether this proposal should be accepted, rejected, or postponed.
  • The CfC will last a minimum of 2 weeks to make sure that all collaborators gets a chance to review. If all relevant parties have explicitly finished reviewing before 2 weeks, the CfC may end early.
  • If there is enough consensus, the CfC will close successfully. If there is no consensus, the proposal could be rejected or go back to be re-edited.

Implementing a proposal

Once a proposal has been accepted, it can start to be implemented. If during implementation, major issues are found, the existing proposal shouldn't be updated but a new proposal should be issued. The old proposal should be updated to link to the new proposal.

Inspiration