fix(#9430): Use dynamic date format for axis with chronological timeUnit (timeUnit with year) #9431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanitw
commented
Sep 11, 2024
| "format": { | ||
| "signal": "timeUnitSpecifier([\"year\",\"month\",\"date\",\"hours\",\"minutes\"], {\"year-month\":\"%b %Y \",\"year-month-date\":\"%b %d, %Y \"})" | ||
| }, | ||
| "format": {}, |
There was a problem hiding this comment.
better remove labelAngle now that we don't need it anymore.
kanitw
commented
Sep 11, 2024
| "format": { | ||
| "signal": "timeUnitSpecifier([\"year\",\"month\",\"date\",\"hours\",\"minutes\"], {\"year-month\":\"%b %Y \",\"year-month-date\":\"%b %d, %Y \"})" | ||
| }, | ||
| "format": {}, |
There was a problem hiding this comment.
better remove labelAngle now that we don't need it anymore.
…Unit with year), by using Vega's default
kanitw
force-pushed
the
kw/9430-timeunit
branch
from
af69ce9 to
6c27ff9
Compare
Deploying vega-lite with
|
| Latest commit: |
6c27ff9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://afca2299.vega-lite.pages.dev |
| Branch Preview URL: | https://kw-9430-timeunit.vega-lite.pages.dev |
kanitw
changed the title
|
TODO: let's also handle categorical -- we should keep the old behavior for categorical |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Using timeUnitSpecifier isn't a good idea for axis. Vega's default is actually better.