Fix version cargo #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feature_port_new_methods_to_booster Co-authored-by: Dmitry Lastovichek <[email protected]>
Fix feats names
use_fresh_lgbm_source_version
vaaaaanquish
requested changes
Nov 10, 2021
| @@ -1,3 +1,3 @@ | |||
| [submodule "lightgbm-sys/lightgbm"] | |||
| path = lightgbm-sys/lightgbm | |||
| url = https://github.com/vaaaaanquish/LightGBM.git | |||
| url = https://github.com/microsoft/LightGBM.git | |||
There was a problem hiding this comment.
@necnec Thx.
I don't think it's a good practice to use microsoft/LightGBM, because many useless files are included in target of build. I removed them in vaaaaanquish/LightGBM.
(commit log: https://github.com/vaaaaanquish/LightGBM/commits/master)
We have 2 way.
- Rebase
microsoft/LightGBMtovaaaaanquish/LightGBMasvendering.- current way
- Create a way to exclude useless files from the latest build of
microsoft/LightGBM.- use
exclude/includein cargo.toml (doc) - improve build.rs
- use
| @@ -1,6 +1,8 @@ | |||
| # lightgbm-rs | |||
| LightGBM Rust binding | |||
|
|
|||
| git clone --recursive https://github.com/aarki/lightgbm-rs.git | |||
There was a problem hiding this comment.
plz
Suggested change
| git clone --recursive https://github.com/aarki/lightgbm-rs.git | |
| git clone --recursive https://github.com/vaaaaanquish/lightgbm-rs.git |
| @@ -14,4 +14,4 @@ libc = "0.2.81" | |||
|
|
|||
| [build-dependencies] | |||
| bindgen = "0.56.0" | |||
| cmake = "0.1" | |||
| cmake = "=0.1.45" | |||
There was a problem hiding this comment.
@necnec I don't like to specify a minor version to avoid conflicts with other libraries. If you have any inconveniences, please write them in the comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.