Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support farm #33

Merged
merged 21 commits into from
Nov 20, 2024
Merged

feat: support farm #33

merged 21 commits into from
Nov 20, 2024

Conversation

ErKeLost
Copy link
Member

Description

Farm wants to use isolated-decl as a type build for farm js plugin and to enhance the adaptability of unplugin

Linked Issues

Additional context

Copy link

stackblitz bot commented Nov 13, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

pkg-pr-new bot commented Nov 13, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/unplugin/unplugin-isolated-decl@33

commit: 21e559b

Copy link

socket-security bot commented Nov 13, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@farmfe/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +236 42.7 MB roland_reed, shulandmimi, wre232114
npm/[email protected] environment +1 1.36 MB rolldownbot
npm/[email protected] environment, filesystem +1 2.63 MB eventualbuddha, lukastaegert, rich_harris, ...2 more

🚮 Removed packages: npm/[email protected], npm/[email protected]

View full report↗︎

@sxzz
Copy link
Member

sxzz commented Nov 15, 2024

Looks like type checking is failed.

@sxzz
Copy link
Member

sxzz commented Nov 18, 2024

It seems farm ships .ts files instead of .d.ts files, causing dts errors in node_modules.

@ErKeLost
Copy link
Member Author

It seems farm ships .ts files instead of .d.ts files, causing dts errors in node_modules.

I fixed this problem on the farm side because the runtime system of the farm does not need to be built, which caused this problem.

@ErKeLost
Copy link
Member Author

@sxzz PTAL❤️ Thanks!

@sxzz sxzz merged commit 9dc11c6 into unplugin:main Nov 20, 2024
10 checks passed
@sxzz
Copy link
Member

sxzz commented Nov 21, 2024

@ErKeLost Could you please add unit tests for Farm to prevent accidental breaks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants