Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding ITelemetry interface #14

Merged
merged 1 commit into from
Dec 19, 2024
Merged

feat: Adding ITelemetry interface #14

merged 1 commit into from
Dec 19, 2024

Conversation

nickrandolph
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

No interface for Telemetry class, making it hard to moq for testing

What is the new behavior?

Telemetry implement ITelemetry

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@jeromelaban jeromelaban merged commit a66f987 into main Dec 19, 2024
5 checks passed
Copy link

welcome bot commented Dec 19, 2024

Congrats on your first pull-request! We ❤ the people who are involved in this project, and we’d love to pay it forward by sending you some swag. If you have any feedback (or ideas how to improve Uno as a open-source project) please open a feedback issue.
giphy
Merci beaucoup 👋

@jeromelaban jeromelaban deleted the dev/nr/interface branch December 19, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants