Skip to content

Commit

Permalink
Introduce new "v" version format
Browse files Browse the repository at this point in the history
we'll keep 0.35.x release branch name. We'll use "v" only for the tag,
this way the documentation branches will work just like before,
we are using "v" only for the github tag
this way we are semver compliant
  • Loading branch information
umbynos committed Oct 19, 2023
1 parent 0f9b8af commit b0855fe
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/release-go-task.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ env:
on:
push:
tags:
- "[0-9]+.[0-9]+.[0-9]+*"
- "v[0-9]+.[0-9]+.[0-9]+*"

jobs:
create-release-artifacts:
Expand Down Expand Up @@ -45,7 +45,7 @@ jobs:
if: matrix.os == 'Windows_32bit'
uses: arduino/create-changelog@v1
with:
tag-regex: '^[0-9]+\.[0-9]+\.[0-9]+.*$'
tag-regex: '^v[0-9]+\.[0-9]+\.[0-9]+.*$'
filter-regex: '^\[(skip|changelog)[ ,-](skip|changelog)\].*'
case-insensitive-regex: true
changelog-file-path: "${{ env.DIST_DIR }}/CHANGELOG.md"
Expand Down
2 changes: 1 addition & 1 deletion Taskfile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ vars:
TIMESTAMP_SHORT:
sh: echo "{{now | date "20060102"}}"
TAG:
sh: echo "$(git tag --points-at=HEAD 2> /dev/null | head -n1)"
sh: echo "$(git tag --points-at=HEAD 2> /dev/null | head -n1 | sed 's/^v//')"
VERSION: "{{if .NIGHTLY}}nightly-{{.TIMESTAMP_SHORT}}{{else if .TAG}}{{.TAG}}{{else}}{{.PACKAGE_NAME_PREFIX}}git-snapshot{{end}}"
CONFIGURATION_PACKAGE: "github.com/arduino/arduino-cli/version"
LDFLAGS: >-
Expand Down
2 changes: 1 addition & 1 deletion docs/UPGRADING.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Here you can find a list of migration guides to handle breaking changes between releases of the CLI.

## 0.35.0
## v0.35.0

### CLI `debug --info` changed JSON output.

Expand Down
2 changes: 1 addition & 1 deletion install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ initDownloadTool() {
checkLatestVersion() {
# Use the GitHub releases webpage to find the latest version for this project
# so we don't get rate-limited.
CHECKLATESTVERSION_REGEX="[0-9][A-Za-z0-9\.-]*"
CHECKLATESTVERSION_REGEX="v?[0-9][A-Za-z0-9\.-]*"
CHECKLATESTVERSION_LATEST_URL="https://github.com/${PROJECT_OWNER}/${PROJECT_NAME}/releases/latest"
if [ "$DOWNLOAD_TOOL" = "curl" ]; then
CHECKLATESTVERSION_TAG=$(curl -SsL $CHECKLATESTVERSION_LATEST_URL | grep -o "<title>Release $CHECKLATESTVERSION_REGEX · ${PROJECT_OWNER}/${PROJECT_NAME}" | grep -o "$CHECKLATESTVERSION_REGEX")
Expand Down

0 comments on commit b0855fe

Please sign in to comment.