-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a couple of changes #15
base: master
Are you sure you want to change the base?
Conversation
(know idee why it was there)
L.Icon.Default.imagePath no longer works because it can point CDN
use roationMarker instead own correct EdgeMarker location remove nowlonger used code
can be used if menus hide part of the map
Hi, thanks for your efforts! I think I would prefer seperate pull requests for each change. Then please explain why you've made the changes. Also, please include documentation and examples in the index.html for each change. I couldn't make out any glaring javascript mistakes, so from this side it should be good. Cheers |
I am glad to help, hope these pull request help.
hopes this helps, you can tell me when you want me to change something. Cheers |
made a couple of changes, and maybe they can be useful for you.
It's now 1 single pull request, but i can split it up if you interesserend.
the change:
edgeMarker points to single coordinate/marker(with bindEdgeMarker) like leaflet tooltip
rotation if marker is done via leaflet-rotatedmarker plugin
location marker is different (more correct). i
in old version it is has x and y values as close as possible to target
now it lies on the intersection of edge and line from mid screen to target
you pass other border then map window. like Leaflet-active-area
has package.json for npm (needs to be updated if you use this)
it removes some options:
but the can be implementer easily.
hope you are interested, comments are welcome. it try to learn javascript