Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the registry backend able to handle V1 manifest responses #289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wk8
Copy link

@wk8 wk8 commented Oct 28, 2020

With a unit test.

Fixes #288

@wk8 wk8 force-pushed the jrouge/prettyjws branch from c646a5e to 3c52c4b Compare October 28, 2020 15:41
@wk8 wk8 force-pushed the jrouge/prettyjws branch from 3c52c4b to 90f69bd Compare October 28, 2020 15:54
@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.79%. Comparing base (e435b83) to head (90f69bd).
Report is 18 commits behind head on master.

Files Patch % Lines
lib/backend/registrybackend/tagclient.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #289      +/-   ##
==========================================
- Coverage   64.80%   64.79%   -0.02%     
==========================================
  Files         186      186              
  Lines        7822     7825       +3     
==========================================
+ Hits         5069     5070       +1     
- Misses       1999     2000       +1     
- Partials      754      755       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails for some repositories with quay.io as a registry backend
1 participant