Add more attribute to fields, fixes #31 #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalekseev
commented
Aug 27, 2019
| @@ -67,10 +79,10 @@ class Field: | |||
| source: Union[Callable, str] = ..., | |||
| label: Optional[str] = ..., | |||
| help_text: str = ..., | |||
| allow_null: bool = ..., | |||
There was a problem hiding this comment.
reordered kwargs to repeat drf order
kalekseev
force-pushed
the
patch-fields
branch
from
3fdf523 to
474ceb3
Compare
|
tests on master fail with the same error on my machine |
kalekseev
force-pushed
the
patch-fields
branch
from
474ceb3 to
d16e23e
Compare
kalekseev
force-pushed
the
patch-fields
branch
3 times, most recently
from
30cbc59 to
144ad00
Compare
kalekseev
force-pushed
the
patch-fields
branch
from
144ad00 to
d532bc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31, this will give type errors when user defined field name clash with one of the attributes eg.:
but it seems like mypy don't provide a way to distinguish class attrs and instance vars python/mypy#1097
Similar issue #12 marked as won't fix.