Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loosen bound on CurrentSiteManager manager type var #2308

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Loosen bound on CurrentSiteManager manager type var #2308

merged 1 commit into from
Aug 2, 2024

Conversation

flaeppe
Copy link
Member

@flaeppe flaeppe commented Aug 2, 2024

The manager accepts any model. It's intended to work on the relation to Site, not the Site declaration itself

Related issues

@flaeppe flaeppe mentioned this pull request Aug 2, 2024
Open
sobolevn
sobolevn approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, docs agree https://docs.djangoproject.com/en/5.0/ref/contrib/sites/#the-currentsitemanager

@sobolevn sobolevn merged commit 10b3058 into typeddjango:master Aug 2, 2024
36 checks passed
@flaeppe flaeppe deleted the fix/current-site-manager-bound branch August 2, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flaeppe @sobolevn