Move @ember/test-waiters
to dependencies
#993
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #992 by moving
@ember/test-waiters
from package.jsondevDependencies
todependencies
.Confirmed this was fixed in my Ember 5.8 app that also uses
ember-sortable
(which requires a peer dependency of"@ember/test-waiters": ">= 3.0.1",
) as follows:package-lock.json
andnode_modules/
npm install
(which generated a new package-lock with@ember/test-waiters
v4 for ember-sortable)ember serve
and saw the same error logged in 992ember-attacher
entry in my package.json with"ember-attacher": "gorner/ember-attacher#move-test-waiters-to-deps",
(i.e. this branch)ember serve
again and saw everything was working as expectedA few notes:
test-waiters
, I've stuck with v3 as there are breaking changes that require dropping support for Ember <4.0, which would imply a major version bump toember-attacher
. This will probably be needed in the near future, but it doesn't appear to be needed to resolve the current issue.ember-try
run forember-release
(Ember 6.0) fails due to breaking changes, specifically the requirement to switch to component template co-location. I see there is a separate issue for this already (Component Templates Co-location and Typescript #978) so for now I am marking theember-release
run asallowedToFail: true
, adding a separate scenario for Ember 5.12, and indicating in the README that the addon is not yet compatible with Ember 6+.peerDependencies
instead so app developers could specify the version oftest-waiters
that works for them. For now it doesn't really make a difference because this package only works with v3 oftest-waiters
anyway. It might make more sense once the Ember 6.x compatibility issues are cleared.