Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX-NULL] Pass parameter to build-push-release-image #361

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

sashuk
Copy link
Collaborator

@sashuk sashuk commented Nov 7, 2024

Description

The build-push-release-image has to pass the registry-name parameter.

Please see https://toptal-core.slack.com/archives/C03VBF0J6/p1731003271609519?thread_ts=1730905440.129699&cid=C03VBF0J6 for more details.

Development checks

  • Add changeset according to guidelines (if needed)
PR commands

List of available commands:

  • @toptal-anvil ping reviewers - Ping FX team for review

@sashuk sashuk added the no-jira label Nov 7, 2024
@sashuk sashuk self-assigned this Nov 7, 2024
@sashuk sashuk requested a review from a team as a code owner November 7, 2024 18:18
Copy link

changeset-bot bot commented Nov 7, 2024

🦋 Changeset detected

Latest commit: c2acb84

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
davinci-github-actions Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sashuk sashuk changed the title Pass parameter to build-push-release-image [FX-NULL] Pass parameter to build-push-release-image Nov 7, 2024
@sashuk sashuk requested review from rasitozcan and p0deje November 7, 2024 18:47
@sashuk
Copy link
Collaborator Author

sashuk commented Nov 7, 2024

@toptal-anvil ping reviewers

@p0deje
Copy link
Member

p0deje commented Nov 7, 2024

  • Please don't merge until we have PR in HireGlobal updating to a new version

@sashuk
Copy link
Collaborator Author

sashuk commented Nov 8, 2024

@p0deje The https://github.com/toptal/hire-global/pull/396 is ready, will merge it right after the release if changes from this pull request

@sashuk sashuk merged commit 807f43f into master Nov 8, 2024
4 of 5 checks passed
@sashuk sashuk deleted the FX-NULL-pass-parameter-sdkjsdf2 branch November 8, 2024 09:12
@github-actions github-actions bot mentioned this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants