Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add GSM actions to public repos #229

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

serbantarmure
Copy link
Contributor

@serbantarmure serbantarmure commented Nov 15, 2023

Description

Those actions are alreadi in toptal/actions

How to test

  • FIXME: Add the steps describing how to verify your changes

Development checks

  • Add changeset according to guidelines (if needed)
PR commands

List of available commands:

  • @toptal-anvil ping reviewers - Ping FX team for review

@serbantarmure serbantarmure self-assigned this Nov 15, 2023
@serbantarmure serbantarmure requested a review from a team November 15, 2023 08:26
Copy link

changeset-bot bot commented Nov 15, 2023

⚠️ No Changeset found

Latest commit: f3770f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the contribution DO NOT ADD MANUALLY label Nov 15, 2023
@toptal-devbot
Copy link

Greetings from FX team, @serbantarmure 👋

Thank you so much for contributing 🙇

We have got high priority ticket generated on our Kanban board so we will do our best to make your experience supreme!

What's next? We will collaborate using this workflow. For you this practically means making sure DONE criteria is met and responding promptly to code review comments 😉

🙏 please, help us improve, rate your contributing experience after merge

@serbantarmure serbantarmure requested review from a team and oleg-polivannyi November 15, 2023 08:27
@serbantarmure
Copy link
Contributor Author

@toptal-anvil ping reviewers

@serbantarmure serbantarmure force-pushed the ci-add-gsm-actions-to-public-repos branch from 7820ffc to 2240ff2 Compare November 15, 2023 08:34
@serbantarmure serbantarmure force-pushed the ci-add-gsm-actions-to-public-repos branch from ec80bd1 to 00056d3 Compare November 15, 2023 11:04
Copy link
Contributor

@Jakub-Kwak Jakub-Kwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
However, I think we should also ask @toptal/secops for a review.

@serbantarmure serbantarmure requested a review from a team November 15, 2023 11:55
@serbantarmure serbantarmure merged commit 06fa09f into master Nov 15, 2023
6 checks passed
@serbantarmure serbantarmure deleted the ci-add-gsm-actions-to-public-repos branch November 15, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants