Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow excluding certain source files from mapping #131

Closed
wants to merge 1 commit into from
Closed

Allow excluding certain source files from mapping #131

wants to merge 1 commit into from

Conversation

rodrigovilina
Copy link

@rodrigovilina rodrigovilina commented Dec 4, 2020

THIS IS STILL MAINLY A DRAFT

A proposal on filtering source files as per suggested on the example in issue #118.

As I suggested there, I think it would be more granular and cleaner to implement if this exclusion was at each strategy level rather than at the MapGenerator level. Also each strategy could be dealt with one at a time, making review easier.

I'll leave comments on what could be simplified with this approach and what parts are ugly and will be refactored once we decide further course of action.

Since this is just a draft I haven't made any test already; I tested it locally (only on coverage strategy) by vendoring the gem and testing on some code that actually called also vendored rspec gem. Test will be my starting point for any further advancement.

I'll expect some type of response before continuing development.

@pirj
Copy link
Contributor

pirj commented Dec 4, 2020

Thanks for the PR!
I suggest summoning @jaimerson @EPecherkin and @pluff as reviewers.

@rodrigovilina
Copy link
Author

I'm picking this up again!

@hebertdougl
Copy link

Hi @vaporyhumo, do we have any news here?

@rodrigovilina
Copy link
Author

Actually no, I switched jobs (I'm at toptal now 😆) and don't need this anymore. I can give it a try if it useful for anyone else tho. We can pair on it too if you want. 👂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants