Allow excluding certain source files from mapping #131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS IS STILL MAINLY A DRAFT
A proposal on filtering source files as per suggested on the example in issue #118.
As I suggested there, I think it would be more granular and cleaner to implement if this exclusion was at each strategy level rather than at the
MapGenerator
level. Also each strategy could be dealt with one at a time, making review easier.I'll leave comments on what could be simplified with this approach and what parts are ugly and will be refactored once we decide further course of action.
Since this is just a draft I haven't made any test already; I tested it locally (only on coverage strategy) by vendoring the gem and testing on some code that actually called also vendored
rspec
gem. Test will be my starting point for any further advancement.I'll expect some type of response before continuing development.