fix: typos in addr_std$10 description
#899
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-trunov
approved these changes
Dec 18, 2024
Shvandre
reviewed
Dec 18, 2024
| @@ -272,7 +272,7 @@ workchain_id:int8 address:bits256 = MsgAddressInt; | |||
|
|
|||
| | Structure | Type | Required | Description | | |||
| |--------------|-------------|----------|------------------------------------------------------------------------------------------------------------------| | |||
| | addr_std$10 | Constructor | Required | `$10` tag means, that in the serialization MsgAddressExt started with a `10` bits describes an external address. | | |||
| | addr_std$10 | Constructor | Required | `$10` tag means, that in the serialization MsgAddressInt started with a `10` bits describes an internal address. | | |||
| | anycast | Anycast* | Optional | Additional address data, currently do not used in ordinary internal messages | | |||
| | workchain_id | int8 | Required | Workchain where smart contract of destination address placed. At moment always equals zero. | | |||
There was a problem hiding this comment.
At moment always equals zero.
I honestly don't really understand what part of documentation it is, but it's definitely not true.
There was a problem hiding this comment.
@Shvandre Let's open a separate issue on this, because this part has not been touched by this PR
Shvandre
reviewed
Dec 18, 2024
| @@ -272,7 +272,7 @@ workchain_id:int8 address:bits256 = MsgAddressInt; | |||
|
|
|||
| | Structure | Type | Required | Description | | |||
| |--------------|-------------|----------|------------------------------------------------------------------------------------------------------------------| | |||
| | addr_std$10 | Constructor | Required | `$10` tag means, that in the serialization MsgAddressExt started with a `10` bits describes an external address. | | |||
| | addr_std$10 | Constructor | Required | `$10` tag means, that in the serialization MsgAddressInt started with a `10` bits describes an internal address. | | |||
There was a problem hiding this comment.
Well, $10 tag means that the address that follows is an internal address written in std form, but in general it doesn't make much difference, it doesn't necessarily need to be fixed.
Shvandre
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addr_stdis an internal address, but the description says it is an external address, which may cause confusion.