Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added native event access for splitPanes hooks #351

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

silicakes
Copy link

Allowing access to the mouse / touch native events

Before this PR, we couldn't have a way of short circuiting events using stopPropagation since the API wouldn't expose the original event.

If you'd add a 'draggable' feature, the two will mix, resulting the following:

May-05-2019 19-39-27

This PR fixes it by exposing the underlying browser event and allowing developers to stop its propagation, along with all the benefits of having native event access.

  • The existing test suites (yarn test) all pass
  • For any new features, documentation has been added
  • For any documentation changes, the text has been proofread and is clear to both experienced users and beginners.
  • Format your code with prettier (npm run prettier).

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 91.489% when pulling 4244b4f on silicakes:master into eb6b2bc on tomkp:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants