Fixes 404 when request header Accept-Encoding not set #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When static middleware is enabled, sending a request without Accept-Encoding set would cause a premature call to pass() before checking if the requested file exists. This meant that calls to normal Express routes would be intercepted and result in 404s.
|
Anything I can do to help move this along? |
|
+1 |
|
👍 Would like to see this merged and also to have the code updated |
|
👍 |
|
curious why this change hasn't been incorporated yet? |
|
@gtracy If you look at the commit history, this repo appears to have been abandoned for about a year. |
|
There's no shortage of installations via NPM so there is plenty of interest in it. And without this fix, it can't be used in some use cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When static middleware is enabled, sending a request without
Accept-Encoding set would cause a premature call to pass()
before checking if the requested file exists. This meant that
calls to normal Express routes would be intercepted and result
in 404s.
This pull request addresses the Issue detailed here:
#47