Supporting Markdown Fenced Code Block #124
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syntax highlighting inside markdown code blocks:
```elixir
Graph.match(
from person in "Person",
where: person.age < 32 and person.title == "Developer",
join: friend in "Person", on: "FRIEND",
join: fof, on: "FRIEND",
join: work, on: "WORKED_WITH",
select: {person.name, friend.name, fof.name, work.name}
)
```
Inspired by https://github.com/mjbvz/vscode-fenced-code-block-grammar-injection-example
sntran
force-pushed
the
markdown-fenced-code-block
branch
from
f2fb409 to
88510bb
Compare
|
Looking good, will test and merge this soon. Tyvm! |
timmhirsens
requested changes
Mar 5, 2018
syntaxes/codeblock.json
Outdated
| "injectionSelector": "L:markup.fenced_code.block.markdown", | ||
| "patterns": [ | ||
| { | ||
| "include": "#plantuml-code-block" |
There was a problem hiding this comment.
where is this "plantuml" comming from?
There was a problem hiding this comment.
Sorry about that "plantuml". It was from another snippet. I have pushed an update that does not have it.
Not only we can avoid matching `elixir` anywhere inside the fenced code block, we also follow the format defined in Visual Studio's [markdown.tmLanguage.json](https://github.com/Microsoft/vscode/blob/master/extensions/markdown-basics/syntaxes/markdown.tmLanguage.json)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syntax highlighting inside markdown code blocks:
Inspired by https://github.com/mjbvz/vscode-fenced-code-block-grammar-injection-example