Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of investigating whether rust-prometheus would benefit from rapidhash, I noticed a few improvements that could be made:
MetricVecCore::children
hashmap uses keys that are hash values, so introducingNoHashHasher
to avoid re-hashing this hash value improves performance.with
andget_metric_with
to accept hashmaps with custom hashers.black_box
in some hashmaps to reduce over-optimisation in microbenchmarks. Could be applied to further benchmarks.Some of the
counter.rs
benchmarks are including hashmap initialisation and destruction. They are also using fixed values and small keys/values, which means benchmarks were unclear over whether FNV or rapidhash are beneficial (hash clashes, etc). Slightly longer key/value lengths are likely to benefit from rapidhash.