Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require Rails 7.2 in web template #1237

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Require Rails 7.2 in web template #1237

wants to merge 2 commits into from

Conversation

louis-antonopoulos
Copy link
Contributor

louis-antonopoulos added a commit that referenced this pull request Nov 1, 2024
@louis-antonopoulos
Simplify determination of unsupported Rails version
62105ed 
#1237 (comment)
slickepinne
slickepinne reviewed Dec 8, 2024
View reviewed changes
Copy link

@slickepinne slickepinne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of also updating the README to name Rails ~> 7.2.0 instead of Rails ~> 7.0 as a requirement for new applications? Or a note that this is the minimum version for new applications?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slickepinne slickepinne slickepinne left review comments

@stevepolitodesign stevepolitodesign stevepolitodesign left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Requiring --skip_rubocop in command line parameters causes script failure when Rails < 7.2
3 participants
@louis-antonopoulos @stevepolitodesign @slickepinne