[React SDK] Fix: Hides custom_jwt profiles from UI #5802
Merged
+34
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
size-limit report 📦
|
packages/thirdweb/src/react/web/ui/ConnectWallet/screens/LinkedProfilesScreen.tsx
Outdated
Show resolved
Hide resolved
joaquim-verges
approved these changes
Dec 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5802 +/- ##
=======================================
Coverage 53.20% 53.20%
=======================================
Files 1101 1101
Lines 59095 59100 +5
Branches 4816 4817 +1
=======================================
+ Hits 31444 31447 +3
- Misses 26934 26936 +2
Partials 717 717
*This pull request uses carry forward flags. Click here to find out more.
|
joaquim-verges
approved these changes
Dec 19, 2024
gregfromstl
added
the
merge-queue
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on enhancing the filtering logic in the `LinkedProfilesScreen` component to exclude specific profile types, namely `guest`, `custom_jwt`, and `custom_auth_endpoint`, from being displayed. It also updates the test cases to reflect these changes.
### Detailed summary
- Updated the filtering logic in `LinkedProfilesScreen.tsx` to exclude `guest`, `custom_jwt`, and `custom_auth_endpoint` profiles.
- Added a test case to verify that `custom_jwt` profiles are not displayed.
- Added a test case to ensure profiles that are not `guest` or `custom_jwt` are displayed correctly.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
joaquim-verges
force-pushed
the
greg/tool-2790-hide-custom_jwt-profile-from-linked-profiles
branch
from
eaf69b8 to
aad6586
Compare
graphite-app
bot
deleted the
greg/tool-2790-hide-custom_jwt-profile-from-linked-profiles
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR enhances the
LinkedProfilesScreencomponent by refining the filtering logic for connected profiles, ensuring that profiles of typeguest,custom_jwt, andcustom_auth_endpointare excluded from display. It also adds tests to verify these changes.Detailed summary
LinkedProfilesScreen.tsxto exclude profiles of typesguest,custom_jwt, andcustom_auth_endpoint.custom_jwtprofiles are not displayed.guestorcustom_jwtare displayed correctly.