[CORE-652] Add chain icon in SingleNetworkSelector + other chain icon related fixes #5794

MananTank · 2024-12-18T16:10:12Z

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR primarily focuses on updating the ChainIcon component and its usage across various files. The changes include modifying how icons are rendered and adjusting their sizes using class names instead of size props.

Detailed summary

Added decoding="async" to an image component.
Replaced size prop with className for ChainIcon in multiple components.
Introduced a new fallbackChainIcon for better handling of missing icons.
Updated ChainIcon implementation to use the Img component.
Adjusted styles in several components to enhance layout and appearance.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

linear · 2024-12-18T16:10:16Z

CORE-652 Add Chain Icon in Network Selector

vercel · 2024-12-18T16:10:16Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 19, 2024 3:06pm

3 Skipped Deployments

Name	Status	Updated (UTC)
docs-v2	⬜️ Skipped (Inspect)	Dec 19, 2024 3:06pm
thirdweb_playground	⬜️ Skipped (Inspect)	Dec 19, 2024 3:06pm
wallet-ui	⬜️ Skipped (Inspect)	Dec 19, 2024 3:06pm

changeset-bot · 2024-12-18T16:10:16Z

⚠️ No Changeset found

Latest commit: 00b6c2e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

MananTank · 2024-12-18T16:10:30Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codecov · 2024-12-18T16:11:56Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.20%. Comparing base (aad6586) to head (00b6c2e).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5794   +/-   ##
=======================================
  Coverage   53.20%   53.20%           
=======================================
  Files        1101     1101           
  Lines       59100    59100           
  Branches     4817     4817           
=======================================
  Hits        31447    31447           
  Misses      26936    26936           
  Partials      717      717

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from aad6586
packages	`50.39% <ø> (ø)`

*This pull request uses carry forward flags. Click here to find out more.

github-actions · 2024-12-18T16:13:48Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	45.02 KB (0%)	901 ms (0%)	3.5 s (+23.62% 🔺)	4.4 s
thirdweb (cjs)	110.76 KB (0%)	2.3 s (0%)	7.3 s (-7.91% 🔽)	9.5 s
thirdweb (minimal + tree-shaking)	5.58 KB (0%)	112 ms (0%)	746 ms (+199.16% 🔺)	858 ms
thirdweb/chains (tree-shaking)	506 B (0%)	10 ms (0%)	108 ms (+167.19% 🔺)	118 ms
thirdweb/react (minimal + tree-shaking)	19.1 KB (0%)	383 ms (0%)	669 ms (-35.49% 🔽)	1.1 s

joaquim-verges · 2024-12-18T23:48:36Z

apps/dashboard/src/components/selects/NetworkSelectorButton.tsx

@@ -196,7 +196,7 @@ export const NetworkSelectorButton: React.FC<NetworkSelectorButtonProps> = ({
          });
        }}
      >
-        <ChainIcon ipfsSrc={chain?.icon?.url} size={20} />
+        <ChainIcon ipfsSrc={chain?.icon?.url} className="size-5" />


btw this is one of the things we should switch to using the react sdk components for!

graphite-app · 2024-12-19T14:55:16Z

Merge activity

Dec 19, 9:55 AM EST: A user added this pull request to the Graphite merge queue.
Dec 19, 10:06 AM EST: A user merged this pull request with the Graphite merge queue.

… related fixes (#5794) ## Problem solved Short description of the bug fixed or feature added  --- ## PR-Codex overview This PR primarily focuses on updating the `ChainIcon` component's implementation and its usage across various files, specifically changing the way the icon's size is handled and integrating a new fallback mechanism. ### Detailed summary - Added `decoding="async"` to an `Image` component. - Replaced `size` prop with `className` for `ChainIcon` across multiple components, adjusting sizes accordingly. - Updated `ChainIcon` implementation to use a new `Img` component. - Introduced a fallback image for `ChainIcon` in case of loading failures. - Added stories for `MultiNetworkSelector` and `SingleNetworkSelector` components. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

vercel bot temporarily deployed to Preview – wallet-ui December 18, 2024 16:10 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground December 18, 2024 16:10 Inactive

vercel bot temporarily deployed to Preview – docs-v2 December 18, 2024 16:10 Inactive

MananTank marked this pull request as ready for review December 18, 2024 16:10

MananTank requested review from jakubkrehel and a team as code owners December 18, 2024 16:10

github-actions bot assigned MananTank Dec 18, 2024

github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 18, 2024

vercel bot deployed to Preview – thirdweb-www December 18, 2024 16:21 View deployment

MananTank force-pushed the 12-18-_core-652_add_chain_icon_in_singlenetworkselector_other_chain_icon_related_fixes branch from 46a959d to 8ad0c17 Compare December 18, 2024 17:55

vercel bot temporarily deployed to Preview – wallet-ui December 18, 2024 17:55 Inactive

vercel bot temporarily deployed to Preview – docs-v2 December 18, 2024 17:55 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground December 18, 2024 17:55 Inactive

vercel bot deployed to Preview – thirdweb-www December 18, 2024 18:03 View deployment

joaquim-verges reviewed Dec 18, 2024

View reviewed changes

joaquim-verges approved these changes Dec 18, 2024

View reviewed changes

MananTank force-pushed the 12-18-_core-652_add_chain_icon_in_singlenetworkselector_other_chain_icon_related_fixes branch from 8ad0c17 to 00b6c2e Compare December 19, 2024 14:55

vercel bot temporarily deployed to Preview – wallet-ui December 19, 2024 14:55 Inactive

vercel bot temporarily deployed to Preview – docs-v2 December 19, 2024 14:55 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground December 19, 2024 14:55 Inactive

vercel bot deployed to Preview – thirdweb-www December 19, 2024 15:06 View deployment

graphite-app bot merged commit 00b6c2e into main Dec 19, 2024
32 checks passed

graphite-app bot deleted the 12-18-_core-652_add_chain_icon_in_singlenetworkselector_other_chain_icon_related_fixes branch December 19, 2024 15:06

vercel bot temporarily deployed to Production – wallet-ui December 19, 2024 15:06 Inactive

vercel bot temporarily deployed to Production – thirdweb_playground December 19, 2024 15:06 Inactive

vercel bot temporarily deployed to Production – docs-v2 December 19, 2024 15:06 Inactive

vercel bot deployed to Production – thirdweb-www December 19, 2024 15:15 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CORE-652] Add chain icon in SingleNetworkSelector + other chain icon related fixes #5794

[CORE-652] Add chain icon in SingleNetworkSelector + other chain icon related fixes #5794

MananTank commented Dec 18, 2024 •

edited by pr-codex bot

Loading

linear bot commented Dec 18, 2024

vercel bot commented Dec 18, 2024 •

edited

Loading

changeset-bot bot commented Dec 18, 2024 •

edited

Loading

MananTank commented Dec 18, 2024 •

edited

Loading

codecov bot commented Dec 18, 2024 •

edited

Loading

github-actions bot commented Dec 18, 2024 •

edited

Loading

joaquim-verges Dec 18, 2024

graphite-app bot commented Dec 19, 2024 •

edited

Loading

[CORE-652] Add chain icon in SingleNetworkSelector + other chain icon related fixes #5794

[CORE-652] Add chain icon in SingleNetworkSelector + other chain icon related fixes #5794

Conversation

MananTank commented Dec 18, 2024 • edited by pr-codex bot Loading

Problem solved

PR-Codex overview

Detailed summary

linear bot commented Dec 18, 2024

vercel bot commented Dec 18, 2024 • edited Loading

changeset-bot bot commented Dec 18, 2024 • edited Loading

⚠️ No Changeset found

MananTank commented Dec 18, 2024 • edited Loading

How to use the Graphite Merge Queue

codecov bot commented Dec 18, 2024 • edited Loading

Codecov Report

github-actions bot commented Dec 18, 2024 • edited Loading

size-limit report 📦

joaquim-verges Dec 18, 2024

Choose a reason for hiding this comment

graphite-app bot commented Dec 19, 2024 • edited Loading

Merge activity

MananTank commented Dec 18, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Dec 18, 2024 •

edited

Loading

changeset-bot bot commented Dec 18, 2024 •

edited

Loading

MananTank commented Dec 18, 2024 •

edited

Loading

codecov bot commented Dec 18, 2024 •

edited

Loading

github-actions bot commented Dec 18, 2024 •

edited

Loading

graphite-app bot commented Dec 19, 2024 •

edited

Loading