extend provider options with httpClientConfig key #771
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can pass options such as timeout proxy to Provider in options, such as
But it is not extensible when need to pass more http client config parameters.
I made a change which add special key for this situation.
This becomes more clear and extensible.
The key name: httpClientConfig, use the guzzle 's client construct parameter, the name is config.
So the key name: httpClientConfig.
If user use the httpClientConfig for option, the option will be override by the httpClientConfig. In test cases, these is a case for this:
Finally this patch is compatible with previous version.
Thanks.