Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Support for Multiple Component Names #3

Merged

Conversation

lilpolymath
Copy link
Collaborator

Description

This PR allows people to add multiple component names for checking during transformation.

Usage

remarkPlugins: [[remarkSandpack, { componentName: ['SandpackEnhanced', 'AnotherSandpackComponent'] }]],

@thecuvii
Copy link
Owner

thecuvii commented Sep 2, 2024

Thank you!

@thecuvii thecuvii changed the title Feat: Add Support for Multiple Component Names feat: Add Support for Multiple Component Names Sep 2, 2024
@thecuvii thecuvii merged commit 4699b8d into thecuvii:master Sep 2, 2024
1 of 9 checks passed
@lilpolymath
Copy link
Collaborator Author

@thecuvii what can be done regarding the failing ci/cd? i want to know how soon you can make a release?

@thecuvii
Copy link
Owner

thecuvii commented Sep 3, 2024

I just manually released version 0.0.4 and hope it works well.

@lilpolymath
Copy link
Collaborator Author

Thank you!

@lilpolymath
Copy link
Collaborator Author

@thecuvii I tried the new version out and I think you should revert to v0.0.3 temporarily.

There is something in the configuration after the migration to tsup fromunbuild that breaks the package.

This error gets thrown

./pages/index.mdx
Error [ERR_REQUIRE_ESM]: require() of ES Module /Users/favour/Documents/coding/current/remark-sandpack/node_modules/.pnpm/[email protected]/node_modules/unist-util-visit/index.js from /Users/favour/Documents/coding/current/remark-sandpack/dist/index.cjs not supported.
Instead change the require of index.js in /Users/favour/Documents/coding/current/remark-sandpack/dist/index.cjs to a dynamic import() which is available in all CommonJS modules.
    at /Users/favour/Documents/coding/current/remark-sandpack/dist/index.cjs:108:78
    at async /Users/favour/Documents/coding/current/remark-sandpack/dist/index.cjs:108:19


> Build failed because of webpack errors
 ELIFECYCLE  Command failed with exit code 1.

@lilpolymath
Copy link
Collaborator Author

Found the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants