Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Export interface RenderHookResult #1049

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

ahummel25
Copy link
Contributor

@ahummel25 ahummel25 commented Apr 15, 2022

What: Small follow up from #991 to simply export the RenderHookResult interface.

Why: This interface can be used in Typescript tests.

How:

Checklist:

  • Documentation added to the
    docs site
  • Tests
  • TypeScript definitions updated
  • Ready to be merged

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8540348:

Sandbox Source
React Configuration
react-testing-library-examples Configuration

@ahummel25
Copy link
Contributor Author

ahummel25 commented Apr 15, 2022

@mpeyper Exporting RenderHookResult interface from discussion over here. This interface works fine as a replacement for the type. So no other changes were needed.

Let me know if I've missed anything.

@ahummel25 ahummel25 changed the title Export interface RenderHookResult fix: Export interface RenderHookResult Apr 15, 2022
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! Thank you 👍

@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #1049 (8540348) into main (9535eff) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main     #1049   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          181       181           
  Branches        34        34           
=========================================
  Hits           181       181           
Flag Coverage Δ
experimental 100.00% <ø> (ø)
latest 100.00% <ø> (ø)
next 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9535eff...8540348. Read the comment docs.

@kentcdodds kentcdodds merged commit 9171163 into testing-library:main Apr 15, 2022
@github-actions
Copy link

🎉 This PR is included in version 13.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants