StartWorkflow with VersioningOverride #6891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlydf
changed the title
carlydf
commented
Nov 26, 2024
ShahabT
approved these changes
Nov 26, 2024
alexshtin
approved these changes
Nov 27, 2024
alexshtin
reviewed
Nov 27, 2024
There was a problem hiding this comment.
I need to go through these tests after merge.
There was a problem hiding this comment.
Hopefully they will be cleaner by then
ShahabT
pushed a commit
that referenced
this pull request
Nov 27, 2024
## What changed? Set Versioning Override in new mutable state created on StartWorkflowExecution and SignalWithStartWorkflowExecution ## Why? So that users can run workflows on specific deployments without needing to run all new unpinned workflows on that deployment. Enables canary workflows for versioning. ## How did you test it? Functional tests that set and get the versioning override. ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Set Versioning Override in new mutable state created on StartWorkflowExecution and SignalWithStartWorkflowExecution
Why?
So that users can run workflows on specific deployments without needing to run all new unpinned workflows on that deployment. Enables canary workflows for versioning.
How did you test it?
Functional tests that set and get the versioning override.
Potential risks
Documentation
Is hotfix candidate?