add functional tests

temporalio · Nov 26, 2024 · 4c31b25 · 4c31b25
1 parent 58cb978
commit 4c31b25
Show file tree

Hide file tree

Showing 2 changed files with 139 additions and 0 deletions.
diff --git a/service/history/api/signalwithstartworkflow/convert.go b/service/history/api/signalwithstartworkflow/convert.go
@@ -59,6 +59,7 @@ func ConvertToStartRequest(
 		WorkflowStartDelay:       request.GetWorkflowStartDelay(),
 		UserMetadata:             request.UserMetadata,
 		Links:                    request.GetLinks(),
+		VersioningOverride:       request.GetVersioningOverride(),
 	}
 
 	return common.CreateHistoryStartWorkflowRequest(namespaceID.String(), req, nil, nil, now)

diff --git a/tests/deployment_test.go b/tests/deployment_test.go
@@ -908,3 +908,141 @@ func (d *DeploymentSuite) TestUpdateWorkflowExecutionOptions_SetPinnedSetUnpinne
 	versioningInfo = descResp.GetWorkflowExecutionInfo().GetVersioningInfo()
 	d.True(proto.Equal(unpinnedOpts.GetVersioningOverride(), versioningInfo.GetVersioningOverride()))
 }
+
+func (d *DeploymentSuite) TestStartWorkflowExecution_WithPinnedOverride() {
+	ctx, cancel := context.WithTimeout(context.Background(), time.Second*5)
+	defer cancel()
+	override := &workflowpb.VersioningOverride{
+		Behavior: enumspb.VERSIONING_BEHAVIOR_PINNED,
+		Deployment: &deploymentpb.Deployment{
+			SeriesName: "seriesName",
+			BuildId:    "A",
+		},
+	}
+
+	resp, err := d.FrontendClient().StartWorkflowExecution(ctx, &workflowservice.StartWorkflowExecutionRequest{
+		Namespace:          d.Namespace(),
+		WorkflowId:         "test-workflow-id",
+		WorkflowType:       &commonpb.WorkflowType{Name: "test-wf-type"},
+		TaskQueue:          &taskqueuepb.TaskQueue{Name: "test-tq", Kind: enumspb.TASK_QUEUE_KIND_NORMAL},
+		Identity:           "test-id",
+		RequestId:          "test-request-id",
+		VersioningOverride: override,
+	})
+
+	d.NoError(err)
+	d.True(resp.GetStarted())
+
+	descResp, err := d.FrontendClient().DescribeWorkflowExecution(ctx, &workflowservice.DescribeWorkflowExecutionRequest{
+		Namespace: d.Namespace(),
+		Execution: &commonpb.WorkflowExecution{
+			WorkflowId: "test-workflow-id",
+			RunId:      resp.GetRunId(),
+		},
+	})
+	d.NoError(err)
+	d.True(proto.Equal(override, descResp.GetWorkflowExecutionInfo().GetVersioningInfo().GetVersioningOverride()))
+}
+
+func (d *DeploymentSuite) TestStartWorkflowExecution_WithUnpinnedOverride() {
+	ctx, cancel := context.WithTimeout(context.Background(), time.Second*5)
+	defer cancel()
+	override := &workflowpb.VersioningOverride{
+		Behavior:   enumspb.VERSIONING_BEHAVIOR_AUTO_UPGRADE,
+		Deployment: nil,
+	}
+
+	resp, err := d.FrontendClient().StartWorkflowExecution(ctx, &workflowservice.StartWorkflowExecutionRequest{
+		Namespace:          d.Namespace(),
+		WorkflowId:         "test-workflow-id",
+		WorkflowType:       &commonpb.WorkflowType{Name: "test-wf-type"},
+		TaskQueue:          &taskqueuepb.TaskQueue{Name: "test-tq", Kind: enumspb.TASK_QUEUE_KIND_NORMAL},
+		Identity:           "test-id",
+		RequestId:          "test-request-id",
+		VersioningOverride: override,
+	})
+
+	d.NoError(err)
+	d.True(resp.GetStarted())
+
+	descResp, err := d.FrontendClient().DescribeWorkflowExecution(ctx, &workflowservice.DescribeWorkflowExecutionRequest{
+		Namespace: d.Namespace(),
+		Execution: &commonpb.WorkflowExecution{
+			WorkflowId: "test-workflow-id",
+			RunId:      resp.GetRunId(),
+		},
+	})
+	d.NoError(err)
+	d.True(proto.Equal(override, descResp.GetWorkflowExecutionInfo().GetVersioningInfo().GetVersioningOverride()))
+}
+
+func (d *DeploymentSuite) TestSignalWithStartWorkflowExecution_WithPinnedOverride() {
+	ctx, cancel := context.WithTimeout(context.Background(), time.Second*5)
+	defer cancel()
+	override := &workflowpb.VersioningOverride{
+		Behavior: enumspb.VERSIONING_BEHAVIOR_PINNED,
+		Deployment: &deploymentpb.Deployment{
+			SeriesName: "seriesName",
+			BuildId:    "A",
+		},
+	}
+
+	resp, err := d.FrontendClient().SignalWithStartWorkflowExecution(ctx, &workflowservice.SignalWithStartWorkflowExecutionRequest{
+		Namespace:          d.Namespace(),
+		WorkflowId:         "test-workflow-id",
+		WorkflowType:       &commonpb.WorkflowType{Name: "test-wf-type"},
+		TaskQueue:          &taskqueuepb.TaskQueue{Name: "test-tq", Kind: enumspb.TASK_QUEUE_KIND_NORMAL},
+		Identity:           "test-id",
+		RequestId:          "test-request-id",
+		SignalName:         "test-signal",
+		SignalInput:        nil,
+		VersioningOverride: override,
+	})
+
+	d.NoError(err)
+	d.True(resp.GetStarted())
+
+	descResp, err := d.FrontendClient().DescribeWorkflowExecution(ctx, &workflowservice.DescribeWorkflowExecutionRequest{
+		Namespace: d.Namespace(),
+		Execution: &commonpb.WorkflowExecution{
+			WorkflowId: "test-workflow-id",
+			RunId:      resp.GetRunId(),
+		},
+	})
+	d.NoError(err)
+	d.True(proto.Equal(override, descResp.GetWorkflowExecutionInfo().GetVersioningInfo().GetVersioningOverride()))
+}
+
+func (d *DeploymentSuite) TestSignalWithStartWorkflowExecution_WithUnpinnedOverride() {
+	ctx, cancel := context.WithTimeout(context.Background(), time.Second*5)
+	defer cancel()
+	override := &workflowpb.VersioningOverride{
+		Behavior:   enumspb.VERSIONING_BEHAVIOR_AUTO_UPGRADE,
+		Deployment: nil,
+	}
+
+	resp, err := d.FrontendClient().SignalWithStartWorkflowExecution(ctx, &workflowservice.SignalWithStartWorkflowExecutionRequest{
+		Namespace:          d.Namespace(),
+		WorkflowId:         "test-workflow-id",
+		WorkflowType:       &commonpb.WorkflowType{Name: "test-wf-type"},
+		TaskQueue:          &taskqueuepb.TaskQueue{Name: "test-tq", Kind: enumspb.TASK_QUEUE_KIND_NORMAL},
+		Identity:           "test-id",
+		RequestId:          "test-request-id",
+		SignalName:         "test-signal",
+		SignalInput:        nil,
+		VersioningOverride: override,
+	})
+
+	d.NoError(err)
+	d.True(resp.GetStarted())
+
+	descResp, err := d.FrontendClient().DescribeWorkflowExecution(ctx, &workflowservice.DescribeWorkflowExecutionRequest{
+		Namespace: d.Namespace(),
+		Execution: &commonpb.WorkflowExecution{
+			WorkflowId: "test-workflow-id",
+			RunId:      resp.GetRunId(),
+		},
+	})
+	d.NoError(err)
+	d.True(proto.Equal(override, descResp.GetWorkflowExecutionInfo().GetVersioningInfo().GetVersioningOverride()))
+}