-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use names already supported by our tools #210
Draft
robholland
wants to merge
16
commits into
main
Choose a base branch
from
rh-var-naming-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids some confusing naming.
robholland
commented
May 29, 2024
Avoid exports.
This avoids printing passwords or other sensitive info in logs.
alexshtin
changed the title
Use names already supported by our tools.
Use names already supported by our tools
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Deprecated some variable names in favour of clearer alternatives.
Why?
This avoids naming that is confusing users new to deploying Temporal, and reduces the amount of mapping needed between the environment and our tools (which already accept the environment variables I'm proposing we use here).
As an added small bonus we get full connection attribute support rather than just MySQL transaction isolation.
The rollout plan would be:
Note that the auto-setup.sh script only supports changing the database name between persistence and visibility configurations. Our config template supports a wider range of visibility overrides, which we should also support in auto-setup.sh. This PR does not attempt to address that now though, and rather aims to keep functionality the same, aside from the connection attribute support mentioned above.
Checklist
Closes
How was this tested: