Use the released CLI artifacts #204
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The version can be bumped automatically using sed: $ sed -i '' 's/^CLI_VER.*/CLI_VER := v0.13.0/' Makefile |
josh-berry
reviewed
May 22, 2024
|
This should also fix #107 |
|
Also makes progress on #43 |
robholland
approved these changes
Jun 11, 2024
| @GOOS=linux GOARCH=$* CGO_ENABLED=$(CGO_ENABLED) make -C $(TCTL_ROOT) build | ||
| @cp ./$(TCTL_ROOT)/tctl build/$*/ | ||
| @cp ./$(TCTL_ROOT)/tctl-authorization-plugin build/$*/ | ||
| @gh release -R temporalio/cli download $(CLI_VER) -p "*linux_$(*).tar.gz" -O - | tar --to-stdout -z -x -v -f - temporal > build/$*/temporal |
There was a problem hiding this comment.
Suggested change
| @gh release -R temporalio/cli download $(CLI_VER) -p "*linux_$(*).tar.gz" -O - | tar --to-stdout -z -x -v -f - temporal > build/$*/temporal | |
| @curl -L https://github.com/temporalio/cli/releases/download/v$(CLI_VER)/temporal_cli_$(CLI_VER)_linux_$(*).tar.gz | tar --to-stdout -z -x -v -f - temporal > build/$*/temporal |
There was a problem hiding this comment.
Preferable to using gh imho.
|
Re-thinking this, I think we should build for temporaliotest and releases differently. Release builds should use released assets rather than building (action can prompt for the various release numbers). Test builds should just use whatever the submodules are at. We don't have the complex docker tags for test builds, so we don't have to calculate any tags. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
We use the pre-built CLI artifacts from the official releases rather than compiling them ourselves
Why?
Calculating the CLI's version based on the tag is a pain (see #203) and I don't want to do that in our Makefile, so we're going to download the appropriate artifact from the official release instead
Note
This is gross but it works. I'm putting this up to stimulate discussion on how we should do it.