Sleep after namespace registration to refresh cache #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+292
to
+293
| echo "Waiting for namespace cache to refresh (sleeping for 10 seconds)..." | ||
| sleep 10 |
There was a problem hiding this comment.
@pdoerner This seems related to the work you were doing for sync namespace registration. Any way we can get around using a sleep here?
There was a problem hiding this comment.
Namespace cache should already support read through if namespace is not found.
I think the problem is there's no read through if search attribute within the namespace config is not found. Then this sleep should happen after search attributes are added?
An easy fix would be allow specifying search attributes when registering namespace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added
sleep 10to wait for namespace cache to refresh.Why?
Sleeping 10 seconds is the only safe way to ensure all namespace caches are refreshed.
Checklist
Closes
How was this tested: