Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add lint #506

Closed
wants to merge 7 commits into from
Closed

chore: add lint #506

wants to merge 7 commits into from

Conversation

neo773
Copy link
Contributor

@neo773 neo773 commented Oct 17, 2023

/claim #505

@algora-pbc algora-pbc bot mentioned this pull request Oct 17, 2023
Closed
@tusharmath tusharmath added maintenance ci: lint Automatically fix the linters issues and make a commit and removed ci: lint Automatically fix the linters issues and make a commit labels Oct 17, 2023
@tusharmath tusharmath changed the title add lint chore: add lint Oct 17, 2023
@tusharmath
Copy link
Contributor

Need to do a test to prove that it's working. Tried to mess around with the ci.yml but I don't think that will work because the CI itself just fails. May be try some whitespace change in a .graphql file will make more sense @neo773 to test out this PR.

@tusharmath
Copy link
Contributor

Not sure why the build is not running @neo773

@tusharmath tusharmath added the ci: lint Automatically fix the linters issues and make a commit label Oct 17, 2023
@tusharmath
Copy link
Contributor

Figured out why the build wasn't running. The YML was invalid. Fixed that. There is another issue, the build doesn't get triggered automatically if I add the label.

@neo773
Copy link
Contributor Author

neo773 commented Oct 17, 2023

@tusharmath Hey, sorry about that was afk so couldn't reply

@tusharmath
Copy link
Contributor

No worries, @neo773 I think you should make this change like we did in benchmark.yml but instead of copying it completely, it would be better to put these changes into benchmark.yml and then rename benchmark.yml to something else - bot.yml. Hope this makes sense.

@tusharmath
Copy link
Contributor

closing in favour of #507

@tusharmath tusharmath closed this Oct 19, 2023
@github-actions github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tusharmath tusharmath tusharmath left review comments

Assignees
No one assigned
Labels
🙋 Bounty claim ci: lint Automatically fix the linters issues and make a commit type: chore Routine tasks like conversions, reorganization, and maintenance work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neo773 @tusharmath