Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Validator] Fix the configuration for custom password strength estimator #20476

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

stof
Copy link
Member

@stof stof commented Dec 17, 2024

Fixes symfony/symfony#59235

service_closure is about building an argument being a closure returning that service. This is not what we need for the custom estimator, where we need to inject the estimator callable.

@xabbuh xabbuh added this to the 7.2 milestone Dec 17, 2024
@carsonbot carsonbot changed the title Fix the configuration for custom password strength estimator [Validator] Fix the configuration for custom password strength estimator Dec 17, 2024
@javiereguiluz
Copy link
Member

Good catch, thanks Christophe.

@javiereguiluz javiereguiluz merged commit b119692 into symfony:7.2 Dec 17, 2024
3 checks passed
@stof stof deleted the patch-1 branch December 17, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants