Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize object property access for StaticString keys #253

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kateinoigakukun
Copy link
Member

No description provided.

@kateinoigakukun kateinoigakukun force-pushed the katei/optimize-staticstring branch from 0a511ce to e1591ce Compare June 11, 2024 12:08
Copy link

github-actions bot commented Jun 11, 2024

Time Change: -1,039ms (12%) 👏

Total Time: 8,116ms

Test name Duration Change
Serialization/JavaScript function call through Wasm import 19ms -3ms (16%) 👏
Serialization/JavaScript function call through Wasm import with int 14ms -2ms (14%) 👏
Object heap/Increment and decrement RC 1,545ms -1,036ms (67%) 🏆
View Unchanged
Test name Duration Change
Serialization/JavaScript function call from Swift 96ms -3ms (2%)
Serialization/Swift Int to JavaScript with assignment 322ms -3ms (0%)
Serialization/Swift Int to JavaScript with call 926ms +7ms (0%)
Serialization/JavaScript Number to Swift Int 293ms -4ms (1%)
Serialization/Swift String to JavaScript with assignment 390ms +4ms (1%)
Serialization/Swift String to JavaScript with call 967ms -14ms (1%)
Serialization/JavaScript String to Swift String 3,531ms +15ms (0%)
View Baselines
Test name Duration
Serialization/Call JavaScript function directly 3ms
Serialization/Assign JavaScript number directly 2ms
Serialization/Call with JavaScript number directly 3ms
Serialization/Write JavaScript string directly 2ms
Serialization/Call with JavaScript string directly 2ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To triage
Development

Successfully merging this pull request may close these issues.

1 participant