Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create new URL when calling goto(...), to handle case where URL is mutated #13196

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Dec 19, 2024

fixes #13187. should probably get a test before we merge it and don't have time for it just now, but wanted to push the fix up anyway


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Dec 19, 2024

🦋 Changeset detected

Latest commit: cf62019

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eltigerchino eltigerchino marked this pull request as ready for review December 19, 2024 05:43
Copy link
Member

@eltigerchino eltigerchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the test

@@ -1741,7 +1741,7 @@ export function goto(url, opts = {}) {
throw new Error('Cannot call goto(...) on the server');
}

url = resolve_url(url);
url = new URL(resolve_url(url));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no big deal but thought maybe it's worth saving creating another instance if one was already created.

Suggested change
url = new URL(resolve_url(url));
const resolved = resolve_url(url);
// force new URL for page.url reactivity
url = url === resolved ? new URL(resolved) : resolved;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

page.url not reactive on the new $app/state module.
3 participants