-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add IsHovered
#116
base: main
Are you sure you want to change the base?
feat: add IsHovered
#116
Conversation
🦋 Changeset detectedLatest commit: 21e6e82 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Thanks for kicking this off! One thing I think we should handle before merging this is ensuring that emulated mouse events on mobile are ignored. One of the pain points of the |
@huntabyte Thanks. I've pushed a quick attempt at detecting hover capability, but based on your comment I'm thinking it's probably not your desired approach. Feel free to revert and/or change as desired if so, as I'm not super across the problem. Self-review - if this is along the lines of what you had in mind, maybe |
Note to self - I've done something similar with https://github.com/svecosystem/svelte-interactions - specifically the |
Oh, I had no idea that existed, nice! I actually prefer actions for this kind of stuff usually anyway, this just felt like a low hanging fruit while I was looking at the repo and comparing to other hook libraries. I wonder if we can create a more generic adapter to rune-ify all those actions and re-use them rather than duplicating the logic in both places. Just comes with the consideration of whether it's worth making it a dependency 🤷♂️ |
https://not-jayden-is-hovered.runed.pages.dev/docs/utilities/is-hovered