Skip to content

Commit

Permalink
Merge pull request #19 from surfalytics/feature/covid-analysis
Browse files Browse the repository at this point in the history
Feature/covid analysis
  • Loading branch information
dimoobraznii1986 authored Dec 13, 2024
2 parents 4b816f9 + 13ee253 commit f75bdd0
Show file tree
Hide file tree
Showing 4 changed files with 36 additions and 30 deletions.
32 changes: 19 additions & 13 deletions dataops-projects/01_git_and_ci_cd/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ help:
Let's start from adding the PR template in the root folder of repo
```bash
touch pr-template.yaml
touch pull_request_template.md
```
PR template
Expand All @@ -182,12 +182,11 @@ PR template
---
# Diligence
-[ ] I have checked affected models for appropriate tests and metadata
-[ ] Project has been built locally
-[ ] Project has been tested locally
-[ ] Each model has YAML file with model description, tests
-[ ] dbt CI pass
- [ ] I have checked affected models for appropriate tests and metadata
- [ ] Project has been built locally
- [ ] Project has been tested locally
- [ ] Each model has YAML file with model description, tests
- [ ] dbt CI pass
```
```bash
Expand Down Expand Up @@ -220,13 +219,21 @@ Adding file `.pre-commit-config.yaml`
```yaml
# Pre-commit that runs locally
fail_fast: false
repos:
# YAML Linter (yamllint)
- repo: https://github.com/adrienverge/yamllint
rev: v1.31.0
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.6.0
hooks:
- id: yamllint
files: \.ya?ml$
- id: trailing-whitespace
- id: check-yaml
- repo: https://github.com/pre-commit/mirrors-prettier
rev: v3.1.0
hooks:
- id: prettier
files: '\.(yaml|yml)$'
# SQL Formatter (sqlfmt)
- repo: https://github.com/tconbeer/sqlfmt
Expand Down Expand Up @@ -335,7 +342,6 @@ jobs:
else
echo "No modified files to check."
fi
```
It shoudl run pre-commit for all files in branch on every push.
Expand Down
2 changes: 1 addition & 1 deletion dataops-projects/01_git_and_ci_cd/scripts/analyze_data.sh
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,4 @@ duckdb "${DB_FILE}" -c ".read ${SQL_FILE}"
# Display results
echo "\nAnalysis complete. Results saved in /app/output/top_20_locations.csv."
echo "\nTop 5 locations by total cases:"
head -n 6 /app/output/top_20_locations.csv
head -n 6 /app/top_20_locations.csv
16 changes: 0 additions & 16 deletions pr-template.yaml

This file was deleted.

16 changes: 16 additions & 0 deletions pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# Description of change

# Links

# Testing

# Before Merge

---
# Diligence

- [ ] I have checked affected models for appropriate tests and metadata
- [ ] Project has been built locally
- [ ] Project has been tested locally
- [ ] Each model has YAML file with model description, tests
- [ ] dbt CI pass

0 comments on commit f75bdd0

Please sign in to comment.