Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add jest dependency and remove extra configs from jest.config.js #4146

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

apsinghdev
Copy link
Member

addresses: #4124

Issues: #4145 (comment)

Screenshot 2024-12-15 at 12 32 40 AM

In this PR I have removed the configurations that we don't need for now and added jest as devDependency to streamline the workflow of adding tests in MB.

After this, tests are working properly without throwing error or creating extra files.

Screenshot 2024-12-15 at 1 14 52 AM

@apsinghdev apsinghdev changed the title Fix/add jest fix: add jest dependency and remove extra configs from jest.config.js Dec 14, 2024
@apsinghdev
Copy link
Member Author

@walterbender Please have a look.

@omsuneri
Copy link
Contributor

@apsinghdev actually to build test for platform style I require to add some more configuration that's why I had added those configuration.

@apsinghdev
Copy link
Member Author

@apsinghdev actually to build test for platform style I require to add some more configuration that's why I had added those configuration.

Can you please list down the configuration you need for platformstyle and reasoning behind it?

@omsuneri
Copy link
Contributor

@apsinghdev i need the test enviorment jsdom to simulate a browser environment

@apsinghdev
Copy link
Member Author

@walterbender As we discussed in the last meeting, I guess, we are on the same ground regarding not adding dom env for now. So this PR is ready for review.

@walterbender
Copy link
Member

Yes... until sort out the dependencies we'll need.

@apsinghdev
Copy link
Member Author

Yes... until sort out the dependencies we'll need.

Oops! I forgot that. I'll write an issue for it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants