Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Added live visual feedback for audio input in Sampler Widget #4117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ravjot07
Copy link

@ravjot07 ravjot07 commented Dec 6, 2024

Fixes: #4005

sampler.mp4

@ravjot07
Copy link
Author

ravjot07 commented Dec 7, 2024

@walterbender sir can you review this PR

@haroon10725
Copy link
Contributor

haroon10725 commented Dec 7, 2024

@ravjot07 I have already created a draft PR for it. I am working on it.

@ravjot07
Copy link
Author

ravjot07 commented Dec 7, 2024

@ravjot07 I have already created a draft PR for it. I am working on it.

Actually I thought it's been a long time till that draft, that why I worked on it.. Sure I have used some other approach for this feature....

@walterbender
Copy link
Member

maybe we can sort out the differences in the two approaches? can you join the Wednesday meeting to discuss?
@haroon10725 @ravjot07

@haroon10725
Copy link
Contributor

haroon10725 commented Dec 8, 2024

@walterbender Can we discuss this in Sunday meet? As I was busy with my exams.

@walterbender
Copy link
Member

walterbender commented Dec 8, 2024

Sure. Let's discuss on the fifteenth.

@ravjot07
Copy link
Author

ravjot07 commented Dec 8, 2024

maybe we can sort out the differences in the two approaches? can you join the Wednesday meeting to discuss? @haroon10725 @ravjot07

@walterbender Sure, I’m a bit new to meetings and don’t know how to join. Could you please guide me?

@walterbender
Copy link
Member

The info is in the MB channel info on Matrix: Music Blocks is a Sugar Labs project (www.sugarlabs.org). https://meet.jit.si/ResponsibleMasksForecastHastily is room for meetings on Wednesdays 7:00 EST (12:00 UTC) and Sundays 7:00 EST (12:00 UTC).

@ravjot07
Copy link
Author

The info is in the MB channel info on Matrix: Music Blocks is a Sugar Labs project (www.sugarlabs.org). https://meet.jit.si/ResponsibleMasksForecastHastily is room for meetings on Wednesdays 7:00 EST (12:00 UTC) and Sundays 7:00 EST (12:00 UTC).

@walterbender

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT]: Add live visual feedback of audio input in Sampler Widget
3 participants