Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add save option #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DipanshKhandelwal
Copy link
Contributor

Save our drawing canvas
fixes #12 .

@walterbender
Copy link
Member

Please use SVG for your icon.
What does win.print() do? Wouldn't we want to save the results in a datastore?

@DipanshKhandelwal
Copy link
Contributor Author

@walterbender ok ill use SVG.
win.print() prints the contents of the window. In this case it will just save our drawing area as a pdf.

@walterbender
Copy link
Member

Yes. But where does it put the PDF?

@DipanshKhandelwal
Copy link
Contributor Author

DipanshKhandelwal commented Dec 19, 2017

@walterbender
Saves it in our local data pc or handset whatever we are using.
It saves locally.

@walterbender
Copy link
Member

SInce this activity is mostly used in Sugarizer, we should make sure it save to the datastore. In Sugar, it presumably will do the right thing, but we need to test it.

@DipanshKhandelwal
Copy link
Contributor Author

@walterbender ok sure 👍

@quozl
Copy link
Contributor

quozl commented Dec 19, 2017

SInce this activity is mostly used in Sugarizer,

Just out of interest, how is this done? How would a user use Sugarizer to download and use this activity?

@DipanshKhandelwal
Copy link
Contributor Author

It will just help them store whatever they just created.
Maybe it's better to use it in Paint Activity.

@walterbender
Copy link
Member

@quozl I was referring to the special glue needed for the Sugarizer datastore. But as far as I know, the only way to add an activity to Sugarizer is to fork it and add your activity. There is a fork of this activity already included in Sugarizer. No idea if the changes were ever merged back here.

@quozl
Copy link
Contributor

quozl commented Dec 19, 2017

only way to add an activity to Sugarizer is to fork it and add your activity

Oh, okay. For a user, this translates to fixed set of activities, and they can't download.

a fork of this activity already included in Sugarizer

I looked, but couldn't find it. Must be under another name.

@walterbender
Copy link
Member

It seems that Lionel has removed dot 2 dot from Sugarizer. It had been one of the original set of activities :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No options to save our canvas
3 participants