-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use picomatch instead of regex #369
Conversation
Apart from my minor question about the test above, this looks great to me. |
As mentioned in #368, this will need to bump the major version of the plugin. Additionally we might want to consider changing the dep string in |
Rounding up some of the issues that will be fixed by this: styled-components/styled-components#3635 |
Looks great to me. Thanks for the proper solution @rockwotj. What's left to get this merged? |
Just need to get @probablyup to notice it 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Interesting, I thought you'd want to bump the major version for this. I suppose there probably aren't that many people relying on the regex matching, though, and this change will fix problems for a bunch of people (especially people using the macro), so maybe it's for the best. |
OMG, this fixed my issue, thanks! I'm using it for displayNames on the react-scripts env <3 |
Honestly should have done this in #354 but I didn't realize you could match relative path patterns using picomatch.