Support GraphQL-core 3.3 #577
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick91
reviewed
Jul 8, 2024
bellini666
reviewed
Jul 9, 2024
| @@ -45,6 +45,9 @@ jobs: | |||
| django-version: | |||
| - 4.2.* | |||
| - 5.0.* | |||
| graphql-core-version: | |||
| - 3.3.0a5 | |||
| - 3.2.3 | |||
There was a problem hiding this comment.
Maybe 3.2.*, just to make sure we get the latest patch release, like we do for django?
Not sure if 3.3.* would work as it is a pre-release, and usually those have to be totally hardcoded
| try: | ||
| from graphql.execution.collect_fields import collect_sub_fields | ||
| except ImportError: | ||
| from graphql.execution.collect_fields import collect_subfields as collect_sub_fields |
There was a problem hiding this comment.
Probably will need to type ignore this line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist