-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add --testTimeout
cli option from jest
#409
add --testTimeout
cli option from jest
#409
Conversation
I was just reading through some of the issues logged in this repo, and found: So I think this PR isn't strictly needed. While this command errors:
I think this works:
So feel free to close this PR. But I'm also fine with it still being merged (so both of the commands above work). |
@skratchdot What version of the test runner are you using? 0.16.0 should allow any jest option without the additional -- . |
@bryanjtc - We are using v16 Again, this works:
This errors:
You should be able to test by checking out the
which will show:
and:
|
That works for me, thank you @skratchdot |
Thanks a lot for your contribution @skratchdot !! |
Thanks for the work on this great library!
We are using it and are experiencing errors like:
We've tried the
--maxWorkers
suggestion from the docs. Instead of ejecting and updating thetestTimeout
, we would prefer to pass it via our jenkins script (which runs on the CI where our tests are timing out- they work fine locally without the timeout).Before this PR, running
test-storybook --testTimeout 20000
results in:error: unknown option '--testTimeout'
Afterwards, it will work.
To test this PR, I ran
yarn build
, and then tested a few commands:set test timeout to 20ms (it should fail):
set test timeout to 20s (it should pass):