Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revise: Create Unique Random Alphanumeric Generator #3

Merged

Conversation

BradenEverson
Copy link
Contributor

@BradenEverson BradenEverson commented Sep 24, 2024

Describe the problem or feature in addition to a link to the issues.
This PR Aims to ensure the Alphanumeric Generator for Docker names generates truly unique names to avoid reusing a name in use. It uses a bloom filter under the hood to ensure this. The generator also now holds a buffer of pregenerated names as to reduce thread_rng creation.

Before submitting this PR, please make sure:

  • You have added a few sentences describing the PR here.
  • You have added yourself or the appropriate individual as the assignee.
  • You have added at least one relevant code reviewer to the PR.
  • Your code builds clean without any errors or warnings.
  • You have added tests (when appropriate).
  • You have updated the README or other documentation to account for these
    changes (when appropriate).
  • You have added an entry to the relevant CHANGELOG.md (see
    "keep a changelog" for more information).
  • Your commit messages follow the conventional commit style.

@BradenEverson BradenEverson force-pushed the revise/generate-unique-names branch from 8e09893 to fc7a1c1 Compare September 26, 2024 16:32
@BradenEverson BradenEverson marked this pull request as ready for review September 26, 2024 16:33
@claymcleod claymcleod merged commit 9bbbae2 into stjude-rust-labs:main Sep 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants