check action objects for implementation use

[with-heart]

Resolves #355
Resolves #373

[changeset-bot]

🦋 Changeset detected

Latest commit: 1816004

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[Andarist]

The 'object' declaration type doesn't exist:

xstate-tools/packages/machine-extractor/src/MachineExtractResult.ts

Lines 603 to 608 in d9cc11d

	declarationTypes: DeclarationType[] = [
	'identifier',
	'inline',
	'unknown',
	'named',
	],

was this maybe intended as a draft PR? 🤔

[with-heart]

It does exist, that default array is just confusing

xstate-tools/packages/machine-extractor/src/types.ts

Lines 87 to 92 in d9cc11d

	export type DeclarationType =
	| 'named'
	| 'inline'
	| 'identifier'
	| 'object'
	| 'unknown';

[with-heart]

Used over here

xstate-tools/packages/machine-extractor/src/actions.ts

Lines 121 to 142 in d9cc11d

	export const ActionAsObjectExpression = createParser({
	babelMatcher: t.isObjectExpression,
	parseNode: (node, context): ActionNode => {
	const id = context.getNodeHash(node);
	for (const prop of node.properties) {
	if (t.isObjectProperty(prop)) {
	if (
	getObjectPropertyKey(prop) === 'type' &&
	t.isStringLiteral(prop.value) &&
	!SUPPORTED_BUILTIN_ACTIONS.includes(prop.value.value)
	) {
	return {
	action: id,
	node,
	name: prop.value.value,
	kind: 'named',
	declarationType: 'object',
	inlineDeclarationId: id,
	};
	}
	}
	}