-
Notifications
You must be signed in to change notification settings - Fork 22
Next Version of sBTC Clarity Scaffolding #354
base: main
Are you sure you want to change the base?
Conversation
Why |
@friedger negative, changing to sbtc-nakamoto. Made that name as a place holder. |
# Conflicts: # clarity/romeo/asset-contract/tests/asset_GetBitcoinWalletPublicKeyCommand.ts # clarity/romeo/asset-contract/tests/asset_SetBitcoinWalletPublicKeyCommand.ts # clarity/romeo/asset-contract/tests/asset_SetBitcoinWalletPublicKeyCommand_NonOwner.ts
c8e6a02
to
1dcab11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (for the changes in romeo/asset-contract) stacks-network/sbtc#354 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is romeo rust binary under clarity
?
Top-level clarity folder does not make sense to me :-)
# epoch_2_4 = 105 | ||
|
||
|
||
# Send some stacking orders |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need stacking order here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarinet.toml is missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the acceptance criteria here?
Should we at least be able to run clarinet check
and yarn test
@@ -0,0 +1,23 @@ | |||
{ | |||
"name": "next-tests", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better name here
The idea here is to create a single Clarity directory that holds different versions of sBTC - both the previous (Romeo) & new (Nakamoto) versions in this case. Re: Rust binary was already in /src file in when copied over but you're right, we might as well remove /src & other files in that level since all Clarity items are in the "asset-contract" directory. |
@friedger I checked both when I rebased (and force-pushed) for
And we still need to port the stuff in |
Reviewed the changes in romeo/asset-contract
and it appears that a wider review is warranted.
Scaffolding For Next Version of sBTC Clarity Contracts
Summary of Changes
This PR is tied to #353 & is an attempt to scaffold the next version of sBTC Clarity contracts based on the design researched & reviewed by the community. There is no code yet in any of the contracts.
Testing
No testing as none of the contracts included here have anything to test.
Risks
This appears relatively risk-free since the only possible this can effect Romeo is if a directory change broke items needed along some process.
How were these changes tested?
They weren't since there is no code inside any of these contracts yet.
Checklist: