Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

Integration: broadcast a withdrawal #351

Draft
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

CAGS295
Copy link
Contributor

@CAGS295 CAGS295 commented Nov 3, 2023

Summary of Changes

Naive test for withdrawals.
Follow up on #215
Blocked #350

Testing

Risks

How were these changes tested?

What future testing should occur?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@CAGS295
Copy link
Contributor Author

CAGS295 commented Nov 3, 2023

blocked by #350

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Attention: 101 lines in your changes are missing coverage. Please review.

Comparison is base (6470223) 43.44% compared to head (805cba5) 43.03%.
Report is 4 commits behind head on main.

Files Patch % Lines
romeo/src/stacks_client.rs 0.00% 36 Missing ⚠️
sbtc-cli/src/commands/withdraw.rs 0.00% 21 Missing ⚠️
sbtc-cli/src/main.rs 0.00% 18 Missing ⚠️
stacks-core/src/address.rs 0.00% 13 Missing ⚠️
sbtc-cli/src/commands/deposit.rs 0.00% 10 Missing ⚠️
sbtc-cli/src/commands/broadcast.rs 0.00% 2 Missing ⚠️
romeo/src/system.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
- Coverage   43.44%   43.03%   -0.41%     
==========================================
  Files          45       45              
  Lines        5467     5519      +52     
  Branches       47       47              
==========================================
  Hits         2375     2375              
- Misses       3091     3143      +52     
  Partials        1        1              
Flag Coverage Δ
unittests 76.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CAGS295 CAGS295 force-pushed the dev/cags295/integration-withdrawal branch from 305907f to 9df1f61 Compare November 6, 2023 22:17
@CAGS295 CAGS295 self-assigned this Nov 9, 2023
@CAGS295 CAGS295 force-pushed the dev/cags295/integration-withdrawal branch from 9df1f61 to 5277247 Compare November 14, 2023 00:24
@CAGS295 CAGS295 force-pushed the dev/cags295/integration-withdrawal branch from 5277247 to 21f97e3 Compare November 14, 2023 06:01
@CAGS295 CAGS295 force-pushed the dev/cags295/integration-withdrawal branch from 21f97e3 to 805cba5 Compare November 16, 2023 06:32
@CLAassistant
Copy link

CLAassistant commented Nov 16, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants