fix: FIM not caching correctly non-python files #408
+331
−123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: #405 The implemented cache was not working correctly because of the way the context is added for FIM requests in other programming languages which are not python. The context for the LLM is provided as single line comments. In Python this means lines which start with the character `#`. Other languages may have other starting sequence for single line comments, e.g. Javascript uses `//`. This PR changes the regex to detect the paths for other languages.
jhrozek
approved these changes
Dec 18, 2024
| self._add_cache_entry(hash_key, context) | ||
| return True | ||
|
|
||
| logger.info(f"FIM entry already in cache: {hash_key}.") |
There was a problem hiding this comment.
this should probably be a debug?
|
|
||
| def _are_new_alerts_present(self, context: PipelineContext, cached_entry: CachedFim) -> bool: | ||
| """Check if there are new alerts present""" | ||
| new_critical_alerts = [ |
There was a problem hiding this comment.
I guess this would not alert if there was the same amount of alerts, but different? (This is probably an edge case..)
|
|
||
| logger.debug(f"Message to hash: {message_to_hash}") | ||
| hashed_content = hashlib.sha256(message_to_hash.encode("utf-8")).hexdigest() | ||
| logger.debug(f"Hashed contnet: {hashed_content}") |
|
|
||
| # Copilot puts the path at the top of the file. Continue providers contain | ||
| # several paths, the one in which the fim is triggered is the last one. | ||
| if provider == "copilot": |
There was a problem hiding this comment.
I think it would be nicer if we had a provider interface instead of having a list of providers in the DB layer, but that's for later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #405
The implemented cache was not working correctly because of the way the context is added for FIM requests in other programming languages which are not python. The context for the LLM is provided as single line comments. In Python this means lines which start with the character
#. Other languages may have other starting sequence for single line comments, e.g. Javascript uses//. This PR changes the regex to detect the paths for other languages.