Make PicassoPainter's request aware of state read changes #2432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picasso-compose/src/main/java/com/squareup/picasso3/compose/PicassoPainter.kt
Outdated
Show resolved
Hide resolved
picasso-compose/src/main/java/com/squareup/picasso3/compose/PicassoPainter.kt
Show resolved
Hide resolved
gamepro65
force-pushed
the
cdrury/requestState
branch
from
6c7b07f to
7633792
Compare
jrodbx
approved these changes
Nov 29, 2023
| val painter = picasso.rememberPainter { | ||
| it.load("http://example.com/") | ||
| } | ||
| Canvas(Modifier.fillMaxSize()) { |
There was a problem hiding this comment.
would it be helpful to use a named argument for the lambda here?
There was a problem hiding this comment.
I don't think so, its the only other argument and generally accepted that Canvas' lambda is DrawScope
picasso-compose/src/main/java/com/squareup/picasso3/compose/PicassoPainter.kt
Outdated
Show resolved
Hide resolved
|
|
||
| // Only launch a new request if anything has actually changed. RequestCreator does not | ||
| // currently implement an equals method, relying here on reference equality, future improvement | ||
| // will be to implement equals which can prevent further re-requests. |
There was a problem hiding this comment.
nice comments/explanations
gamepro65
force-pushed
the
cdrury/requestState
branch
from
7633792 to
224ee40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #2423
This allows state objects the ability to update a request without requiring a recomposition + another rememberPainter call with a different key. If a state change occurs during the initial composition (ex. as a result of measured size becoming available) then we need to cancel the original request. Unfortunately Picasso will already be executing the original request; to avoid this race condition I've included a main synchronization mechanism to prevent the request from running until the current frame has completed which allows us time to cancel the initial request before processing anything unnecessarily. This only effects cases where the image does not exist in the cache already as those would be synchronously returned in time for the first frame.