Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No template syntax in html attributes. #102

Open
willstott101 opened this issue Mar 1, 2016 · 6 comments
Open

No template syntax in html attributes. #102

willstott101 opened this issue Mar 1, 2016 · 6 comments

Comments

@willstott101
Copy link

<i class="large shop{{ basket.error|yesno:" red," }} icon"></i> for instance is really hard to read.

Happens a LOT with href too.

image

@willstott101
Copy link
Author

That's actually a good example where it might be nice to have filters highlighted regardless of if they are recognised or not.

@squ1b3r
Copy link
Owner

squ1b3r commented Mar 1, 2016

It wasn't really possible when I initially made it. With the latest release, there is a new and better way to make syntax files now but it will require a lot of work and I don't really use Djaneiro myself these days because I switched to PyCharm. I'm might make a new syntax file on the future but no promises. Sorry.

@willstott101
Copy link
Author

Ok, no worries, may take a gander myself at some point.

@willstott101
Copy link
Author

I've just started: https://github.com/willstott101/django-sublime-syntax only done comments so far but feels pretty easy with the new syntax engine.

@squ1b3r
Copy link
Owner

squ1b3r commented Nov 22, 2019

@willstott101 you are welcome to contribute if you want. Djaneiro is still being used by many people and it would be nice if we could solve some of those issues.

@willstott101
Copy link
Author

willstott101 commented Nov 22, 2019

Once I feel like it's in a reasonable position I'll open a PR for sure (I made sure I used the same license to make that easier). Perhaps trying to make a new Package is totally pointless... to be honest I thought there was more non-syntax stuff in this Package than snippets and it made sense to have a separate pure-syntax Package. I'm not so sure now, I may cancel my packagecontrol.io request if I end up trying to merge into this repo before it's accepted.

EDIT: I also had no idea how long it would take to develop, it's been quicker than I imagined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants