-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect Comment syntax highlighting for block comments with string note #124
Comments
Without looking too deep into the source code, my initial guess would be that we would need to add a regex here: https://github.com/squ1b3r/Djaneiro/blob/master/Syntaxes/HTML%20(Django).tmLanguage ? |
I've been meaning to get round to opening a PR for merging: https://github.com/willstott101/django-sublime-syntax I'd think it'd be easier to fix this syntax error in the .sublime-syntax format which my repo there uses. The newer syntax also fixes: #102 |
@willstott101 that would be great. I think that's my only complaint about the package, other than that it works perfect for my use cases. |
This has been resolved. |
Block comments allows for an optional string note. See https://docs.djangoproject.com/en/3.0/ref/templates/builtins/#comment
Without a string note, the comment syntax highlighted appears a muted gray as expected.
However, when a note is added it no longer appears as if it was a comment:
Expected:
Should be also be a muted gray color.
Basically the following two formats should have grayed out appearance.
I'm not sure if this is by design and if I just have to change something in my settings.
The text was updated successfully, but these errors were encountered: